Skip to content

Add pull request:write permissions to nightly build Workflow #2148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

guineveresaenger
Copy link

@guineveresaenger guineveresaenger commented Mar 25, 2025

Proposed fix for #2145.

update: it looks like the nightly build needs more than pull request permissions: https://github.com/pulumi/pulumi-aws-native/actions/runs/14070213304/job/39402424273#step:16:6

update: the nightly job pushes directly to a branch on origin so it needs contents permissions as well.
Successful run here: https://github.com/pulumi/pulumi-aws-native/actions/runs/14070892002/job/39404595733
Generated PR here: #2149

Copy link
Contributor

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.80%. Comparing base (914e3e9) to head (d0575d8).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2148   +/-   ##
=======================================
  Coverage   50.80%   50.80%           
=======================================
  Files          49       49           
  Lines        7088     7088           
=======================================
  Hits         3601     3601           
  Misses       3235     3235           
  Partials      252      252           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@guineveresaenger guineveresaenger marked this pull request as draft March 25, 2025 21:58
@guineveresaenger guineveresaenger marked this pull request as ready for review March 25, 2025 22:24
Copy link
Member

@mjeffryes mjeffryes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to get this into ci-mgmt as well

Copy link
Member

@t0yv0 t0yv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we do so right away?

# WARNING: This file is autogenerated - changes will be overwritten if not made via https://github.com/pulumi/ci-mgmt

this is liable to be wiped out.

@guineveresaenger
Copy link
Author

yep, closing in favor of pulumi/ci-mgmt#1468

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants