Skip to content

Update rubocop version, this fixes BlockAlignment Error#3378

Merged
danadoherty639 merged 1 commit intomainfrom
rubucop-update
Mar 10, 2025
Merged

Update rubocop version, this fixes BlockAlignment Error#3378
danadoherty639 merged 1 commit intomainfrom
rubucop-update

Conversation

@danadoherty639
Copy link
Contributor

@danadoherty639 danadoherty639 commented Feb 26, 2025

This fixes BlockAlignment issue when running rubocop, incompatible version needs updated to 1.72.2

38 errors occurred:
An error occurred while Layout/BlockAlignment cop was inspecting /Users/dana.doherty/Documents/devx/bolt/acceptance/files/example_apply/lib/facter/myfact.rb:3:0.
An error occurred while Layout/BlockAlignment cop was inspecting /Users/dana.doherty/Documents/devx/bolt/acceptance/files/example_apply/lib/puppet/type/warn.rb:3:0.
An error occurred while Layout/BlockAlignment cop was inspecting /Users/dana.doherty/Documents/devx/bolt/acceptance/setup/common/pre-suite/010_install_ruby.rb:3:0.
An error occurred while Layout/BlockAlignment cop was inspecting /Users/dana.doherty/Documents/devx/bolt/acceptance/setup/git/pre-suite/010_install_git.rb:3:0.
An error occurred while Layout/BlockAlignment cop was inspecting /Users/dana.doherty/Documents/devx/bolt/bolt-modules/boltlib/lib/puppet/datatypes/applyresult.rb:38:0.
An error occurred while Layout/BlockAlignment cop was inspecting /Users/dana.doherty/Documents/devx/bolt/bolt-modules/boltlib/lib/puppet/datatypes/containerresult.rb:30:0.
An error occurred while Layout/BlockAlignment cop was inspecting /Users/dana.doherty/Documents/devx/bolt/bolt-modules/boltlib/lib/puppet/datatypes/future.rb:12:0.
An error occurred while Layout/BlockAlignment cop was inspecting /Users/dana.doherty/Documents/devx/bolt/bolt-modules/boltlib/lib/puppet/datatypes/resourceinstance.rb:46:0.
An error occurred while Layout/BlockAlignment cop was inspecting /Users/dana.doherty/Documents/devx/bolt/bolt-modules/boltlib/lib/puppet/datatypes/result.rb:32:0.
An error occurred while Layout/BlockAlignment cop was inspecting /Users/dana.doherty/Documents/devx/bolt/bolt-modules/boltlib/lib/puppet/datatypes/resultset.rb:37:0.
An error occurred while Layout/BlockAlignment cop was inspecting /Users/dana.doherty/Documents/devx/bolt/bolt-modules/boltlib/lib/puppet/datatypes/target.rb:58:0.
An error occurred while Layout/BlockAlignment cop was inspecting /Users/dana.doherty/Documents/devx/bolt/bolt-modules/boltlib/lib/puppet/functions/background.rb:7:0.
An error occurred while Layout/BlockAlignment cop was inspecting /Users/dana.doherty/Documents/devx/bolt/bolt-modules/boltlib/lib/puppet/functions/catch_errors.rb:8:0

Fixed a few warning errors with new Rubocop version, added to do list to break fixes into smaller chunks without breaking anything

This PR also updates actions/cache@v1 to actions/cache@v4

@danadoherty639 danadoherty639 marked this pull request as ready for review February 28, 2025 08:01
@danadoherty639 danadoherty639 requested a review from a team as a code owner February 28, 2025 08:01
Copy link
Contributor

@LukasAud LukasAud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danadoherty639 danadoherty639 merged commit b47e205 into main Mar 10, 2025
23 checks passed
@gavindidrichsen gavindidrichsen deleted the rubucop-update branch March 19, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants