-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bring OpenBSD package handling up to date to what is in the #9301
Open
buzzdeee
wants to merge
16
commits into
puppetlabs:main
Choose a base branch
from
buzzdeee:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ports tree and gets packaged.
Can one of the admins verify this patch? |
* pkg.conf file is long gone * drop versionable * drop upgradeable * add support for package branches
I used the update of the puppet agent to 8.6.0 on OpenBSD -current to integrate that new package handling into the Puppet agent package for OpenBSD. |
Please! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ports tree and gets packaged.
versionable and upgradeable don't really make much sense on OpenBSD, and they way overcomplicate the provider. However, it could be readded if someone can come up with a compelling usecase ;)
OpenBSD supports package branches, i.e. for puppet, there's puppet 7 and puppet 8, both conflict, and cant be installed at the same time, but with Puppet current package provider, it was impossible to easily tell which of the branches to use. Only when using a fixed "version", or "latest", but that was still quite clumsy, and either had to update the version any time in Hiera when updating puppet, or when using latest, you couldn't choose to install Puppet 7.
There are other packages that have branches, i.e. gimp, which has a stable, and a snapshot branch. They don't conflict with each other, so can be installed in parallel. Puppet with the current package provider would be unable to handle that.
To add support for branches, a new property won't work for those packages with branches that can be installed in parallel, i.e. install both versions of Gimp via Puppet.
The way around it is to specify the branch suffxed to the package name with a leading %
so similarly I would run
I would now use puppet alike:
to manage both packages.