fix(MODULES-5225): include app_name in cache key for virt_dir_path #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imaqsood
force-pushed
the
MODULES-5225
branch
2 times, most recently
from
0da4511 to
e44ccf1
Compare
Ensure app_name is part of the cache key to prevent incorrect cache hits when the same sitename and name are used with different app_name values. Also refactored the method for clarity and safer string handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ensure app_name is part of the cache key to prevent incorrect cache hits when the same sitename and name are used with different app_name values.
Also refactored the method for clarity and safer string handling.
Checklist
puppet apply)