Rewrite loadjson to use the modern function API

[ekohl]

Summary

This also resolves a bug where JSON.parse returned a StringIO. To properly catch this, the tests are rewritten to avoid mocking where possible. Exceptions are with external URLs and where a failure is expected.

Related Issues (if any)

Fixes #1414

Checklist

• 🟢 Spec tests.
• 🟢 Acceptance tests.
• Manually verified. (For example puppet apply)

[alexjfisher]

At the same time, shouldn't we namespace this function and create a (deprecated) shim like we started with a lot of the other functions?

[ekohl]

I didn't consider this.

[alexjfisher]

Rubocop is complaining here. Are you specifically using JSON.load over JSON.parse to address the bug you mentioned?

[ekohl]

It's copied from the old code to remain compatible.

[alexjfisher]

What happened to all the basic authentication related code and tests?

[ekohl]

Good point. I assumed it would just use the credentials from the URI, but it doesn't.

Simple reproducer:

# dnf install httpd
# htpasswd -c /etc/httpd/passwords admin supersecret
# echo 'Hello World!' > /var/www/html/index.html

Now replace Require all granted in /etc/httpd/conf/httpd.conf with the following:

    AuthType Basic
    AuthName "Restricted Files"
    AuthUserFile "/etc/httpd/passwords"
    Require valid-user

Verify it works with curl:

# curl -s -I localhost | head -n 1
HTTP/1.1 401 Unauthorized
# curl -s -I localhost -u admin:supersecret | head -n 1
HTTP/1.1 200 OK

Then we can write a small Ruby script:

require 'open-uri'

uri = URI.parse('http://admin:supersecret@localhost/index.html')
options = {}
if uri.user
  options[:http_basic_authentication] = [uri.user, uri.password]
  uri.user = nil
end
uri.open(**options) do |f|
  puts f.read
end