Initial PR of OkApi port to PROS 4 #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Files should use the destination (sigbots branch) code, I believe the pros version is newer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Changes are detailed within the "OkApi_Notes.docx" within the repo. Otherwise, changes generally include the removal of legacy PID motor functions, changes to function calls used within imu.cpp, and adding some missing C library includes in two files.
Motivation
To assist in the porting of the OkApi library to PROS 4
Possible Drawbacks
Code may need slightly more adjustment to work with PROS 4.0.3, but at the moment this shouldn't be an issue.
Verification Process
Code was checked through locally compiling with cmake as well as the test script in the repo
Applicable Issues
None as of now