-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add a button to reset the PROS conductor file #224
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works
automated CI run of prettier is bugged
please pass ci check
AndrewLuGit
requested changes
May 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add an entry in the package.json for pros.resetConductor, otherwise it looks good
BennyBot
reviewed
May 20, 2024
Co-authored-by: BennyBot <[email protected]>
AndrewLuGit
approved these changes
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Jackman3323
added a commit
that referenced
this pull request
May 21, 2024
* ✨ Add a button to reset the PROS conductor file (#224) * pros c reset button Works * fix prettier warning automated CI run of prettier is bugged * run prettier on new file please pass ci check * Allow conductor reset regardless of vscode context Co-authored-by: BennyBot <[email protected]> * Add package.json entry for resetConductor --------- Co-authored-by: BennyBot <[email protected]> * 🐛 Use tag versions to select CLI version on welcome screen (#225) Co-authored-by: Andrew Lu <[email protected]> * update package.json --------- Co-authored-by: Jack Hughes <[email protected]> Co-authored-by: BennyBot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested Feature
A button that calls pros c reset and gives the user the associated warning and choice to continue.
Benefits of Feature
The current template/depot system sometimes causes the conductor file to break. This seems to be particularly common on macOS currently (#222). While we are looking into the root cause(s) of this issue, this button can operate as a stopgap for those users who have broken conductor files. Additionally, resetting the conductor is a frequent debugging step and a popular command.