Migration setup v2

[zaryab2000]

List of changes:

1. Locker Contract : removed counter state as it was no longer needed.
2. Locker Contract: Included msg.sender in the emit log as well - this fixes add msg.sender in event emitted when lock() #13
3. Shifted all tests to foundry tests. ( do not remove legacytest)
4. Included deployment scripts
5. separated utils into two sections: utils ( main file for fetch and merkle generation ) and testUtils ( only for testing )
6. Included configs in utils : to ensure we aren't hardocding scripts itself. instead we change variables as and when needed.
7. Also included a START_BLOCK config param for fetching events. We don't wanna fetch events from ZERO block.

[Copilot]

Pull Request Overview

This PR aims to update the migration setup by moving tests to Foundry, introducing deployment scripts, and separating utility functions and configuration. Key changes include:

• Updating Merkle tree functions to remove unused parameters.
• Integrating configuration for deployment and event fetching (including a START_BLOCK parameter).
• Updating test utilities and simulation scripts to reflect the new structure and deployment addresses.

Reviewed Changes

Copilot reviewed 31 out of 31 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
script/utils/merkle.js	Removed the unused “id” parameter from hashing, proof, and verify functions.
script/utils/getRoot.js	Updated to load claims using a configurable path.
script/utils/fetchAndStoreEvents.js	Replaced hardcoded values with config values and introduced event aggregation.
script/utils/config.js	Added config options for locker and output paths.
script/testUtils/*.js	Fixed import paths to reference updated utils directory.
script/testSimulations/*.js	Updated simulation scripts with additional lock amounts and revised approval amounts.
script/deploy/*.s.sol	Deployment scripts for MigrationRelease and MigrationLocker using a transparent proxy.
README.md	Updated instructions and release ratio details to match the new setup.

Comments suppressed due to low confidence (2)

script/testUtils/getPoof.js:1

• The file name 'getPoof.js' appears to be a typo. Consider renaming it to 'getProof.js' for consistency with the function it imports.

const whitelist = require("../../output/claims.json");

README.md:75

• The documented migration ratios in this section appear inconsistent. Please verify that the 'Total migration ratio: 1:15' (locked:received) is correct and aligns with the intended distribution.

**Instant Release**: 50% of the locked amount is immediately available

[Copilot]

[nitpick] Consider removing or limiting debugging log outputs within loops to avoid potential performance issues in production environments.

Suggested change

	events.forEach(event => {
	const address = event.args.recipient;
	const amount = BigInt(event.args.amount.toString());
	if (addressAmounts[address]) {
	// Address already exists, add to existing amount
	addressAmounts[address] = addressAmounts[address] + amount;
	console.log(`📝 Combined amount for ${address}`);
	} else {
	// First occurrence of this address
	addressAmounts[address] = amount;
	}
	});
	const combinedLogs = [];
	events.forEach(event => {
	const address = event.args.recipient;
	const amount = BigInt(event.args.amount.toString());
	if (addressAmounts[address]) {
	// Address already exists, add to existing amount
	addressAmounts[address] = addressAmounts[address] + amount;
	combinedLogs.push(`📝 Combined amount for ${address}`);
	} else {
	// First occurrence of this address
	addressAmounts[address] = amount;
	}
	});
	combinedLogs.forEach(log => console.log(log));

[Copilot]

Review the vested release expected amount calculation to ensure it aligns with the intended release ratio described in the updated release model.

Suggested change

	const expected = (BigInt(amount) * 75n) / 10n;
	const VESTED_RELEASE_RATIO_NUMERATOR = 75n; // Replace with actual numerator from updated release model
	const VESTED_RELEASE_RATIO_DENOMINATOR = 10n; // Replace with actual denominator from updated release model
	const expected = (BigInt(amount) * VESTED_RELEASE_RATIO_NUMERATOR) / VESTED_RELEASE_RATIO_DENOMINATOR;

[Copilot]

[nitpick] Consider correcting the comment to 'DON'T MARK THIS AS ZERO' to improve clarity.

Suggested change

	START_BLOCK: 0, // Block number where to start fetching events from ( DON't MARK THIS AS ZERO)
	START_BLOCK: 0, // Block number where to start fetching events from (DON'T MARK THIS AS ZERO)