Make CUDA optional for app too #49
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Actually, it looks mostly like the main blocker is a pure-cpu version of the PixelCornerProjector. |
rpavlik
force-pushed
the
optional-cuda-app
branch
from
a0609ca to
c800636
Compare
Owner
|
Regarding PixelCornerProjector: I think that this should only be used by the stereo depth estimation tool, which is not required for the calibration process itself, and (due to lacking optimizations) is already very slow when running on a GPU. So this tool should be even less practical on a CPU in this form. Thus, in case your use-case does not require it, perhaps the depth estimation tool could simply be #ifdef'd out for now if CUDA is not available. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #48 but this one is not complete - it looked like the CUDA dep was much deeper in the app, sadly, since that's what I wanted to try out first. I probably won't have time to do more with this for a while, but feel free to take this as a starting point.