Fix keyboard focus indicator for "View Details" button in Report Card manifest section #5000
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds visible focus indicators to the "View Details" button in the Report Card's Manifest region to improve keyboard accessibility for users navigating with keyboard-only input.
Problem
The "View Details" button (implemented as a Shoelace
sl-details
component) in the Report Card's Manifest section did not display a visible focus indicator when navigated to using keyboard navigation. This creates an accessibility barrier for keyboard-only users and users with low vision who cannot determine which element currently has focus.Solution
Added CSS focus styles using the
:focus-visible
pseudo-class to ensure the button shows a clear visual indicator when focused via keyboard navigation:Changes Made
apps/pwabuilder/src/script/pages/app-report.ts
(8 lines of CSS)apps/pwabuilder/tests/report-card.spec.ts
to verify focus indicator visibility.gitignore
to exclude test artifactsTesting
Screenshot
The screenshot shows the "View Details" button with a visible purple focus outline when navigated to using keyboard navigation.
Accessibility Impact
This change ensures compliance with WCAG 2.2 Success Criterion 2.4.7 (Focus Visible) by providing a clear visual indication of which interactive element has keyboard focus, enabling keyboard-only users to successfully navigate the Report Card interface.
Fixes #4976.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
googlechromelabs.github.io
node install.mjs
(dns block)https://storage.googleapis.com/chrome-for-testing-public/127.0.6533.88/linux64/chrome-headless-shell-linux64.zip
node install.mjs
(http block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.