Fix keyboard focus indicators for All Settings dropdown and Join Us button in Portals #5001
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When navigating via keyboard in the PWA Builder Portals section, the 'All Settings' dropdown button and 'Join Us' button do not display visible focus indicators, making it unclear which element is currently focused. This violates WCAG 2.2 focus-visible accessibility guidelines and creates barriers for keyboard-only users and users with low vision.
Solution
Added proper
:focus-visible
CSS styles to both components to display clear black outlines when focused via keyboard navigation.Changes Made
1. All Settings Dropdown (
windows-form.ts
):2. Join Us Button (
arrow-link.ts
):Testing
Accessibility Compliance
Both elements now show clearly visible black outlines (2px solid black with 2px offset) when focused using keyboard navigation, meeting WCAG 2.2 Focus Visible (SC 2.4.7) requirements.
Before/After
The test page demonstrates the fixed focus indicators working correctly:
Fixes #4975.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
googlechromelabs.github.io
node install.mjs
(dns block)https://storage.googleapis.com/chrome-for-testing-public/127.0.6533.88/linux64/chrome-headless-shell-linux64.zip
node install.mjs
(http block)https://storage.googleapis.com/chrome-for-testing-public/127.0.6533.88/linux64/chrome-linux64.zip
node install.mjs
(http block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.