Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid js execution on gc #2273

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

avoid js execution on gc #2273

wants to merge 1 commit into from

Conversation

madanagopalt
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Apr 23, 2020

Codecov Report

Merging #2273 into master will increase coverage by 0.26%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2273      +/-   ##
==========================================
+ Coverage   74.03%   74.29%   +0.26%     
==========================================
  Files         137      148      +11     
  Lines       21409    24097    +2688     
==========================================
+ Hits        15851    17904    +2053     
- Misses       5558     6193     +635     
Impacted Files Coverage Δ
src/rtScriptV8/rtScriptNode.cpp 85.64% <83.33%> (+0.08%) ⬆️
src/rtScriptV8/rtWrapperUtils.cpp 75.39% <100.00%> (+0.80%) ⬆️
src/rtThreadPool.h 50.00% <0.00%> (-50.00%) ⬇️
src/rtScriptV8/rtFunctionWrapper.h 56.52% <0.00%> (-10.15%) ⬇️
src/pxOffscreen.h 55.55% <0.00%> (-6.95%) ⬇️
src/rtThreadTask.cpp 87.50% <0.00%> (-4.17%) ⬇️
examples/pxScene2d/src/pxText.h 87.50% <0.00%> (-3.41%) ⬇️
examples/pxScene2d/src/Spark.cpp 64.23% <0.00%> (-3.37%) ⬇️
examples/pxScene2d/src/pxImage.h 78.57% <0.00%> (-2.92%) ⬇️
src/pxIView.h 22.22% <0.00%> (-2.78%) ⬇️
... and 106 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cfdf8a...d548ffd. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants