Move _feols_input_checks functions from feols.py to dev_utils.py

[csanthoshkumarraju]

Hi,

Issue Addressed:

This PR addresses the issue in #869, where all functions defined at the end of feols.py, starting with _feols_input_checks, should be moved into the dev_utils.py script.

Summary of Changes:

Moved the _feols_input_checks function from the end of feols.py to dev_utils.py to improve modularity and code organization.
Updated the necessary imports in feols.py to import the _feols_input_checks function from dev_utils.py.

Detailed Explanation:

The _feols_input_checks function was previously located at the end of feols.py. I have commented it out in feols.py and moved it to dev_utils.py for better structure and reusability.
After moving the function, I imported it into feols.py to ensure no disruptions in functionality.

Testing:

All existing tests were executed and passed successfully after making the changes.
The pixi run lint command showed no linting issues, ensuring code consistency.

This is my first open-source contribution. Could you please check the pull request and merge it if everything is in order?

Thank you!

[codecov]

Codecov Report

Attention: Patch coverage is 14.28571% with 12 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
pyfixest/utils/dev_utils.py	7.69%	12 Missing ⚠️

Flag	Coverage Δ
core-tests	79.84% <14.28%> (ø)
tests-extended	?
tests-vs-r	47.83% <14.28%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
pyfixest/estimation/feols_.py	84.59% <ø> (-5.78%)	⬇️
pyfixest/estimation/fepois_.py	90.04% <100.00%> (ø)
pyfixest/estimation/vcov_utils.py	57.89% <ø> (ø)
pyfixest/utils/dev_utils.py	72.41% <7.69%> (-11.37%)	⬇️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[csanthoshkumarraju]

pre-commit.ci autofix

[s3alfisc]

Hi @csanthoshkumarraju, thanks so much for this! Looks good at a first glance. Could you delete all the coverage files?

[csanthoshkumarraju]

Hi @s3alfisc ,

Thank you so much for the feedback! I really appreciate it and it motivates me to keep improving.

As requested, I have deleted the coverage files. Could you kindly review the changes and merge the pull request if everything looks good? If you need any further assistance or clarification, feel free to let me know.

Also, I’ve attached the screenshot below for your reference.

Thanks again!

Best regards,
Santhosh

[s3alfisc]

Hi, I meant all these files - can you please delete them / delete them from the commit history? Then I think this will be ready to be merged. Thanks!

[s3alfisc]

pre-commit.ci autofix

[csanthoshkumarraju]

Hi @s3alfisc

I apologize for the confusion earlier. I have deleted all the files as requested. Could you please check the screenshots?

If everything looks good, could you please merge my pull request?

[s3alfisc]

If everything looks good, could you please merge my pull request?

Sorry, I don't really follow, why the urgency to merge this?

[csanthoshkumarraju]

Hi @s3alfisc

I’m sorry again for any confusion. There is no urgency in merging the pull request. I’m just kindly requesting if you could please review and merge it when you have the time.

Thank you!