MAINT: Use mypy recursive type support #2898
Conversation
In mypy>=1.7 recursive type support is built-in.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2898 +/- ##
=======================================
Coverage 96.53% 96.53%
=======================================
Files 53 53
Lines 8918 8918
Branches 1635 1635
=======================================
Hits 8609 8609
Misses 185 185
Partials 124 124 ☔ View full report in Codecov by Sentry. |
|
Is this failing because mypy==1.4.1 is being used in ci.txt? Fixable if |
|
These are docs build issues, not related to mypy. They might be fixed with a more recent sphinx version, but this requires further updates to other packages and the configuration file: #2573 (comment) I had planned to do this in the summer, but have been quite busy with more important tasks. I will try to find some time in the next weeks. |
|
Apparently Sphinx does not like recursive types. Does delayed evaluation with |
|
Thanks @stefan6419846. Upstream solution may be simplest, although is low priority. |
In mypy>=1.7 recursive type support is built-in.
In mypy>=1.7 recursive type support is built-in.
In mypy>=1.7 recursive type support is built-in.
In mypy>=1.7 recursive type support is built-in.
In mypy>=1.7 recursive type support is built-in.
Recursive types like the following are now supported by mypy: OutlineType = List[Union[Destination, "OutlineType"]] However, this recursuve type does not work with the Sphinx documentation generator; update comment to reflect this.
In mypy>=1.7 recursive type support is built-in.