Skip to content

Commit

Permalink
'[pre-commit.ci 🤖] Apply code format tools to PR'
Browse files Browse the repository at this point in the history
  • Loading branch information
pre-commit-ci[bot] committed Oct 9, 2024
1 parent 39efd1b commit 369a35b
Show file tree
Hide file tree
Showing 3 changed files with 70 additions and 70 deletions.
38 changes: 19 additions & 19 deletions community/translation.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# pyOpenSci GitHub processes for translation teams
# pyOpenSci GitHub processes for translation teams

This document outlines the process for managing translation of pyOpenSci content in our [python-package-guide](https://github.com/pyOpenSci/python-package-guide) repository. It covers:

Expand All @@ -8,35 +8,35 @@ This document outlines the process for managing translation of pyOpenSci content

## Guidelines for a translation-related Pull Request

* When a translation-related PR has been submitted, it should be reviewed and ultimately approved by at least one other person (who is not the PR owner) on the language team associated with the submitted PR.
* A PR can not be merged without at least one approval from someone on the relevant code-owner team.
* All questions, errors, and suggestions must be addressed before the PR is merged.
* When a translation-related PR has been submitted, it should be reviewed and ultimately approved by at least one other person (who is not the PR owner) on the language team associated with the submitted PR.
* A PR can not be merged without at least one approval from someone on the relevant code-owner team.
* All questions, errors, and suggestions must be addressed before the PR is merged.

These are the checks a reviewer should incorporate into their review.
* Verify that the translation can be built in the PR branch without warnings
* Example for Spanish translation: `nox -s docs-live-lang -- es`
* The command can be used for any language by swapping out the language tag at the end. A list of Sphinx language tags can be [found here](https://www.sphinx-doc.org/en/master/usage/configuration.html#confval-language).
* Go through the file and ensure that the translation makes sense, using the following checks:
* There are no typos
* Technical terms can be easily understood
* Sentence structure makes sense for the target language
* Use suggestions for any errors that are found. This has two purposes:
* It makes it easier for the contributor to make changes
* It gives credit to the PR reviewer as a coauthor in the final commit to main
* Example for Spanish translation: `nox -s docs-live-lang -- es`
* The command can be used for any language by swapping out the language tag at the end. A list of Sphinx language tags can be [found here](https://www.sphinx-doc.org/en/master/usage/configuration.html#confval-language).
* Go through the file and ensure that the translation makes sense, using the following checks:
* There are no typos
* Technical terms can be easily understood
* Sentence structure makes sense for the target language
* Use suggestions for any errors that are found. This has two purposes:
* It makes it easier for the contributor to make changes
* It gives credit to the PR reviewer as a coauthor in the final commit to main

## GitHub infrastructure for the translation teams

pyOpenSci will create and maintain a team for each language using CODEOWNERS files. This ensures that every time there is a PR, and some `*.po` files are modified, the appropriate team is requested to review the PR. All members of the translation team will have merge permissions.
pyOpenSci will create and maintain a team for each language using CODEOWNERS files. This ensures that every time there is a PR, and some `*.po` files are modified, the appropriate team is requested to review the PR. All members of the translation team will have merge permissions.

The current translation teams consist of:
The current translation teams consist of:

### Spanish
* [Felipe Moreno](https://github.com/flpm)
* [Roberto Pastor Muela](https://github.com/RobPasMue)
* [Felipe Moreno](https://github.com/flpm)
* [Roberto Pastor Muela](https://github.com/RobPasMue)

### Japanese
* [Tetsuo Koyama](https://github.com/tkoyama010)
* [Kozo Nishida](https://github.com/kozo2)
* [Tetsuo Koyama](https://github.com/tkoyama010)
* [Kozo Nishida](https://github.com/kozo2)

Current translation teams can expand their teams and add additional members by updating the CODEOWNERS file.

Expand Down
Loading

0 comments on commit 369a35b

Please sign in to comment.