Added content to CI section on htmlproofer #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pre-commit.ci autofix |
lwasser
approved these changes
Sep 30, 2024
lwasser
reviewed
Sep 30, 2024
lwasser
reviewed
Sep 30, 2024
|
pre-commit.ci autofix |
|
@kierisi awesome! thanks! i made some edits and will merge once CI is happy again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on review feedback in #92 (originally given in #79), I've added a first pass at information on htmlproofer. a couple of notes:
htmlprooferwhen it's being used within github. I don't know if we want to keep those conventions or not, as I seem to recall we default to 'htmlproofer'.I tried to introduce breaking changes to get HTMLProofer to throw an error and was unsuccessful. I can file an issue in case anyone else comes across an error so that we can get a "wild-caught" screenshot, but also as a reminder to myself to keep trying to get htmlproofer to break.nevermind, I actually managed to introduce a bunch of breaks that tripped up htmlproofer and got me the images I needed!