Breakdown the classification module into algorithms and wrappers #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qbarthelemy
requested changes
Feb 25, 2025
Co-authored-by: Quentin Barthélemy <[email protected]>
Co-authored-by: Quentin Barthélemy <[email protected]>
Co-authored-by: Quentin Barthélemy <[email protected]>
Co-authored-by: Quentin Barthélemy <[email protected]>
Co-authored-by: Quentin Barthélemy <[email protected]>
Co-authored-by: Quentin Barthélemy <[email protected]>
Co-authored-by: Quentin Barthélemy <[email protected]>
Co-authored-by: Quentin Barthélemy <[email protected]>
Co-authored-by: Quentin Barthélemy <[email protected]>
Co-authored-by: Quentin Barthélemy <[email protected]>
qbarthelemy
reviewed
Feb 25, 2025
Co-authored-by: Quentin Barthélemy <[email protected]>
qbarthelemy
requested changes
Feb 25, 2025
qbarthelemy
reviewed
Feb 25, 2025
qbarthelemy
reviewed
Feb 25, 2025
Co-authored-by: Quentin Barthélemy <[email protected]>
Co-authored-by: Quentin Barthélemy <[email protected]>
qbarthelemy
reviewed
Feb 26, 2025
|
Thank you for the review @qbarthelemy !
Do you have in mind a specific scenario that you would like me to cover in this PR? |
|
Unit tests We must add |
|
Ok. The test showed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The classification module is becoming quiet big.
This PR breaks it into wrappers (such as QuantumNCH) and core algorithms (such as NearestConvexHull).
The PR also extracts the
get_docplex_optimizer_from_params_bagmethod toutils.py.Closes #257