Switch to using xr.open_dataset to read nwp data #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RubenImhoff
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
Hi @dnerini,
Great work! This is indeed a typical problem with the open_mfdataset method. Your changes seem fine to me. If @cvelascof also approves, we're good to go, I'd say.
cvelascof
requested changes
Jun 22, 2024
There was a problem hiding this comment.
HI @dnerini, thanks for tracking these bugs.
I may prefer to replace open_mfdataset for open_dataset inside of _import_bom_nwp_data_xr and other similar functions in the other importers, rather than eliminate these functions.
This may allow us to identify the real reason of the segmentation fault later on.
|
hi @cvelascof , thanks for the feedback. I implemented your suggestion in 3b3c34f, I hope I got it right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3