parse_uri should accept and ignore optional image parameter (#114)

pyauth · Jan 30, 2021 · 1c4f85e · 1c4f85e
1 parent 7183690
commit 1c4f85e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/pyotp/__init__.py b/src/pyotp/__init__.py
@@ -82,7 +82,7 @@ def parse_uri(uri: str) -> OTP:
             otp_data['interval'] = int(value)
         elif key == 'counter':
             otp_data['initial_count'] = int(value)
-        else:
+        elif key != 'image':
             raise ValueError('{} is not a valid parameter'.format(key))
 
     if not secret:

diff --git a/test.py b/test.py
@@ -417,6 +417,10 @@ def test_algorithms(self):
         with self.assertRaises(ValueError):
             otp.provisioning_uri(name='n', issuer_name='i', image='nourl')
 
+        otp = pyotp.parse_uri(otp.provisioning_uri(name='n', issuer_name='i', image='https://test.net/test.png'))
+        self.assertEqual(hashlib.sha512, otp.digest)
+
+
 class Timecop(object):
     """
     Half-assed clone of timecop.rb, just enough to pass our tests.