-
-
Notifications
You must be signed in to change notification settings - Fork 728
Introduce @deprecated decorators for functions and enforce warnings as errors in tests #4757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RohitP2005
wants to merge
40
commits into
pybamm-team:develop
Choose a base branch
from
RohitP2005:issue#2028
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
ff6a817
Deprecation for deprecated fucntions
RohitP2005 7f34a0b
style: pre-commit fixes
pre-commit-ci[bot] 3da7140
Merge branch 'pybamm-team:develop' into issue#2028
RohitP2005 3a15fe8
Removed previous deprecation warnings
RohitP2005 9c500b5
Merge branch 'pybamm-team:develop' into issue#2028
RohitP2005 949571b
Added -W flag to pytest
RohitP2005 3f327cb
Custom decorator added and filterwarningn adjusted
RohitP2005 9d29350
Merge branch 'develop' into issue#2028
RohitP2005 1eb61a0
setuptools fix
RohitP2005 47051ab
Merge branch 'develop' into issue#2028
RohitP2005 e57a1fd
using agriyakhetarpal's approach to ignore external warnings
RohitP2005 dba1881
Merge branch 'develop' into issue#2028
RohitP2005 c48ed38
Merge branch 'pybamm-team:develop' into issue#2028
RohitP2005 b91e9ce
Update pyproject.toml
RohitP2005 c564c87
moving deprecation decorator to uitl.py
RohitP2005 52e610b
Merge branch 'develop' into issue#2028
RohitP2005 a4025a1
style: pre-commit fixes
pre-commit-ci[bot] 33ff787
Moved decorators to utils and corrected pytest config
RohitP2005 9d9c1bf
Added msg parameter in deprecation decorator
RohitP2005 139704c
Applied decorators to necessary functions
RohitP2005 808d5cd
Corrected imports for utils
RohitP2005 28f5397
Update pyproject.toml
RohitP2005 a703eca
Update pyproject.toml
RohitP2005 8784b35
removed old deprecation warningsdfasf
RohitP2005 7902c43
deprecation Decorator accepts msg as a dictionary
RohitP2005 eaf0994
Merge branch 'develop' into issue#2028
arjxn-py 930190b
Update pyproject.toml
RohitP2005 6c76623
Merge branch 'develop' into issue#2028
RohitP2005 422029a
fixed deprecated tests
RohitP2005 6e2eb5a
Merge branch 'pybamm-team:develop' into issue#2028
RohitP2005 840b696
test coverage for deprecate warnings
RohitP2005 194c657
Added _set_paramters function in the test
RohitP2005 41e58e3
Merge branch 'develop' into issue#2028
RohitP2005 a565419
Unit test fixed
RohitP2005 0bf9abf
doctests fix
RohitP2005 6a63a05
Updated setuptools version
RohitP2005 444cf08
Merge branch 'develop' into issue#2028
RohitP2005 6db0714
Merge branch 'pybamm-team:develop' into issue#2028
RohitP2005 2e8d684
added test auxiliary domains
RohitP2005 71a5197
Merge branch 'pybamm-team:develop' into issue#2028
RohitP2005 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -41,6 +41,7 @@ dependencies = [ | |
| "posthog", | ||
| "pyyaml", | ||
| "platformdirs", | ||
| "deprecation" | ||
| ] | ||
|
|
||
| [project.urls] | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.