Skip to content

Remove IREE solver #5065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Remove IREE solver #5065

wants to merge 1 commit into from

Conversation

kratman
Copy link
Contributor

@kratman kratman commented Jun 17, 2025 •
edited
Loading

Description

Recreated #4585 since it was badly out of date.

This is part of the push towards enabling python 3.13 and numpy 2.0 in PyBaMM.

Reasoning:

  • Jax needs to be updated to remain compatible.
  • Only certain versions of Jax match IREE and it is not trivial to fix the issues
  • The IREE solver is only single precision
  • The IREE solver is not currently included with pybammsolvers

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)

Important checks:

Please confirm the following before marking the PR as ready for review:

  • No style issues: nox -s pre-commit
  • All tests pass: nox -s tests
  • The documentation builds: nox -s doctests
  • Code is commented for hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@kratman kratman self-assigned this Jun 17, 2025
@kratman kratman requested a review from a team as a code owner June 17, 2025 16:57
@kratman kratman changed the title Remove IREE Remove IREE solver Jun 17, 2025
@kratman kratman marked this pull request as draft June 17, 2025 20:30
@BradyPlanden BradyPlanden mentioned this pull request Jun 18, 2025
Merged
@kratman kratman mentioned this pull request Jun 20, 2025
Closed
5 tasks
@kratman
Copy link
Contributor Author

kratman commented Jun 25, 2025

Closing so I can break this up into smaller chunks

@kratman kratman closed this Jun 25, 2025
@kratman kratman deleted the feat/removeIREE2 branch June 25, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kratman kratman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kratman