Change PyCFunction cast in function_record_pyobject.h to sidestep unhelpful compiler warnings.
#5608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elpful compiler warnings.
/__w/pybind11/pybind11/include/pybind11/detail/function_record_pyobject.h:41:39: error: do not cast 'PyObject *(PyObject *, PyObject *, PyObject *)' (aka '_object *(_object *, _object *, _object *)') to 'PyCFunction' (aka '_object *(*)(_object *, _object *)') through 'void *' [bugprone-casting-through-void,-warnings-as-errors]
41 | reinterpret_cast<PyCFunction>(reinterpret_cast<void *>(reduce_ex_impl)),
| ^
This was referenced Apr 9, 2025
henryiii
approved these changes
Apr 10, 2025
Thanks for confirming! I added this to the PR description:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With a little help from ChatGPT: https://chatgpt.com/share/67f60e22-8964-8008-aca6-1e13d24e019e
Although rwgk wants/needs to take full responsibility for the
void *cast trick/hack:Casting to
void *before casting toPyCFunctionis a more portable and easier way to silence compiler warnings.Using C++-style casts is mostly a matter of style. Probably, C-style casts would work, too.
Suggested changelog entry: