Skip to content

Conversation

@hannesdelbeke
Copy link
Contributor

move duplicate code regarding plugin validation,
from plugins_from_module and register_plugin, into plugin_is_valid

refactor only no new code.

swapped
continue -> return False
raise Exception -> return False

depending on where plugin_is_valid is used we then raise an exception or debug log anyway, so logic remains same.

now there's no more dupe code for plugin validation, and it's all in the place where we expect it: the plugin_is_valid function

@hannesdelbeke
Copy link
Contributor Author

this should be ready for merge if we are happy with this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant