Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sections picked-up #107

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Sections picked-up #107

wants to merge 10 commits into from

Conversation

davidlatwe
Copy link

@davidlatwe davidlatwe commented Nov 12, 2018

Picked up

I have merged @BigRoy 's sections branch (PR #58) to my end and did some conflict resolve, this should be workable. Beside resolving the conflict with current master branch, I also updated Qt.py.

Wondering if there are anyone could help on testing ?

Thanks !

@mkolar
Copy link
Member

mkolar commented Jan 17, 2019

It seems to be working fine, however I'm unable to toggle instances in the list view. I can turn it on a off in the first tab, with the simplified view, in the middle tab plugins and instances cannot be clicked.

@davidlatwe
Copy link
Author

Thanks for testing @mkolar !

in the middle tab plugins and instances cannot be clicked.

:O That's weird, I can toggle them on my machine.

Anyhow, I also spot some issue that need to be fixed, and compared with QML :

lite_fix

But I am not sure when I can back on this to dig deep and fix, hope soon !

@BigRoy
Copy link
Member

BigRoy commented Jan 18, 2019

There are some plugins and instances missing their checkbox in Lite

I believe this is a Lite feature, hiding checkboxes that cannot be toggled anyway. Right @mottosso?

EDIT: Why they are missing on the left hand side I'm not sure though? Is that because they are "locked" and also cannot be toggled? (Mandatory?) If so, it would be correct they are missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants