-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add other MLDSA test vectors #14470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DarkaMaul
wants to merge
2
commits into
pyca:main
Choose a base branch
from
trail-of-forks:dm/mldsa-vectors
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+4
−0
Open
Add other MLDSA test vectors #14470
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -300,6 +300,10 @@ Custom asymmetric vectors | |
| encrypted with ``pbeWithSHA1And128BitRC4``. The password is ``password``. | ||
| * ``asymmetric/PKCS8/enc-rsa-pkcs8-pbkdf2-0iter.pem`` a PKCS8 encoded | ||
| structure with an invalid PBKDF2 iteration count (zero). | ||
| * ``asymmetric/MLDSA/mldsa44_pub.der`` and ``asymmetric/MLDSA/mldsa44_priv.der`` | ||
| a PKCS8 encoded key pair for ML-DSA-44 generated by OpenSSL. | ||
| * ``asymmetric/MLDSA/mldsa65_noseed_priv.der`` a PKCS8 encoded ML-DSA-65 private | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This appears to have serialized nothing:
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think that's intended, it's for a test for an invalid key: def generate_mldsa65_noseed(output_dir: str) -> None:
# ML-DSA-65 OID: 2.16.840.1.101.3.4.3.18
# Generate an ML-DSA-65 PKCS#8 key whose inner privateKey is an
# empty SEQUENCE (0x30 0x00) — i.e. the "both" SEQUENCE form with
# no seed present. This exercises the InvalidKey error path in the
# Rust parser when seed is None.(from the script used to generate it) |
||
| key serialized without the seed. | ||
|
|
||
| Key exchange | ||
| ~~~~~~~~~~~~ | ||
|
|
||
Binary file not shown.
Binary file not shown.
Binary file added
BIN
+22 Bytes
vectors/cryptography_vectors/asymmetric/MLDSA/mldsa65_noseed_priv.der
Binary file not shown.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mldsa44_priv.derappears to contain both seed and pub/priv so this is the OpenSSL "kitchen sink" format I think?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when I decode it I see this, which only contains the seed?
The OCTET STRING has tag 0, which should mean that it's the
seedvariant from theML-DSA-44-PrivateKeyCHOICE: