You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@saimani5 - I made significant revisions to your functions in this commit. I haven't tested this function or the new changes though. I think it should work. One of the challenges was that USID >> sidpy.Dataset >> USID is not the best of tests since sidpy.Dataset allows a lot more diversity in the dimension types. Also note that sidpy.Dataset assumes that dimensions are arranged from slowest to fastest varying and this is not the default assumption in USID. This is the reason you will find the slow_to_fast being explicitly set to True now. Also, doing an np.array(object) effectively forces the data into memory and this would cause problems if the data is much larger than memory. This is the reason that sidpy.Dataset extends Dask.array rather than numpy arrays. Anyway, please do go over these changes. We should not / cannot close #56 until this function is heavily tested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #56