Skip to content

Added USID_Writer#68

Merged
ssomnath merged 2 commits intopycroscopy:masterfrom
saimani5:master
Jan 29, 2021
Merged

Added USID_Writer#68
ssomnath merged 2 commits intopycroscopy:masterfrom
saimani5:master

Conversation

@saimani5
Copy link
Contributor

Issue #56

@ssomnath ssomnath merged commit 65ee58b into pycroscopy:master Jan 29, 2021
@ssomnath ssomnath linked an issue Jan 30, 2021 that may be closed by this pull request
@ssomnath
Copy link
Member

@saimani5 - I made significant revisions to your functions in this commit. I haven't tested this function or the new changes though. I think it should work. One of the challenges was that USID >> sidpy.Dataset >> USID is not the best of tests since sidpy.Dataset allows a lot more diversity in the dimension types. Also note that sidpy.Dataset assumes that dimensions are arranged from slowest to fastest varying and this is not the default assumption in USID. This is the reason you will find the slow_to_fast being explicitly set to True now. Also, doing an np.array(object) effectively forces the data into memory and this would cause problems if the data is much larger than memory. This is the reason that sidpy.Dataset extends Dask.array rather than numpy arrays. Anyway, please do go over these changes. We should not / cannot close #56 until this function is heavily tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Write sidpy.Dataset to USID HDF5

2 participants