-
-
Notifications
You must be signed in to change notification settings - Fork 38
Set up criterion for benchmarking #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Change SummarySet up criterion for benchmarking and implemented
Added Files
How can I customize these reviews?Check out the Hyperlint AI Reviewer docs for more information on how to customize the review. If you just want to ignore it on this PR, you can add the Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
CodSpeed Performance ReportMerging #197 will create unknown performance changesComparing Summary
Benchmarks breakdown
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, overall looks good though we need to fix the codspeed measurement in CI.
Also, maybe split the error impls into their own PR for sake of making those changes more visible in their own right?
crates/jiter/benches/main.rs
Outdated
@@ -1,5 +1,4 @@ | |||
use codspeed_bencher_compat::{benchmark_group, benchmark_main, Bencher}; | |||
use std::hint::black_box; | |||
use criterion::{black_box, criterion_group, criterion_main, Criterion}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use codspeed_criterion_compat
here so that the benchmarks continue to be measured in CI.
std::error::Error
for error typesa6ebbcf
to
67ca987
Compare
82ecdc7
to
0b7a0e5
Compare
Looks like this introduces a dependency on |
a10651b
to
51d14c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super, thanks! 👍
This commit uses criterion for its benchmarking suite. Also contains a README about benchmarking instructions.