Add LOGFIRE_BASE_URL env var support and refactor LOGFIRE_TOKEN#119
Merged
Add LOGFIRE_BASE_URL env var support and refactor LOGFIRE_TOKEN#119
Conversation
…o use `ConfigValue` Add `LOGFIRE_BASE_URL` env var with priority: programmatic > env var > credentials file > token region. Refactor `LOGFIRE_TOKEN` to use `OptionalConfigValue` pattern consistent with other env vars. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
cetra3
previously requested changes
Mar 2, 2026
Contributor
cetra3
left a comment
cetra3
left a comment
There was a problem hiding this comment.
We should align with the base url derivation from tokens that happens in the python version
Align with the Python SDK's base URL derivation from tokens by adding support for stagingus and stagingeu regions, mapping to .pydantic.info domains. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
Author
|
Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LOGFIRE_BASE_URLenv var support with priority order: programmaticwith_base_url()>LOGFIRE_BASE_URLenv var > credentials file > token region parsingLOGFIRE_TOKENenv var to useOptionalConfigValuepattern, consistent with all other env varsTest plan
test_base_url_from_env_var— env var sets base URLtest_base_url_programmatic_overrides_env— programmatic config takes precedencetest_token_from_env_var— token via env var works with refactored codetest_base_url_env_overrides_credentials_file— env var overrides credentials file🤖 Generated with Claude Code