Skip to content

refactor: add screenshots to write tokens guide#1722

Open
ddanielcruzz wants to merge 1 commit intomainfrom
daniel/update-write-tokens-guide
Open

refactor: add screenshots to write tokens guide#1722
ddanielcruzz wants to merge 1 commit intomainfrom
daniel/update-write-tokens-guide

Conversation

@ddanielcruzz
Copy link
Contributor

No description provided.

@cloudflare-workers-and-pages
Copy link

Deploying logfire-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 58e70cc
Status: ✅  Deploy successful!
Preview URL: https://2ba03118.logfire-docs.pages.dev
Branch Preview URL: https://daniel-update-write-tokens-g.logfire-docs.pages.dev

View logs

Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Open in Devin Review

@@ -12,12 +12,19 @@ You can create a write token by following these steps:
1. Open the **Logfire** web interface at [logfire.pydantic.dev](https://logfire.pydantic.dev).
2. Select your project from the **Projects** section on the left hand side of the page.
3. Click on the ⚙️ **Settings** tab in the top right corner of the page.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 Unused image file write-tokens-settings.png added but not referenced

The directory docs/images/how-to-guides/ contains four write-tokens-* images, but only three are referenced in the markdown:

  • write-tokens-page.png (line 17)
  • write-tokens-new-form.png (line 21)
  • write-tokens-created.png (line 26)

The file docs/images/how-to-guides/write-tokens-settings.png exists in the repo but is not referenced anywhere in the guide. This could be an oversight — perhaps it was intended to accompany step 3 (clicking the Settings tab) but was forgotten. It won't cause any build errors, but it adds an unused asset to the repository.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant