fix: annotate always-detected packages in logfire run suggestions#1736
Open
nightcityblade wants to merge 2 commits intopydantic:mainfrom
Open
fix: annotate always-detected packages in logfire run suggestions#1736nightcityblade wants to merge 2 commits intopydantic:mainfrom
nightcityblade wants to merge 2 commits intopydantic:mainfrom
Conversation
…estions Mark sqlite3, urllib (stdlib) and requests (OTel dependency) with an asterisk and a footnote in the recommendation output, so users know these are always detected and can be safely ignored if not used in their code.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Author
|
Gentle ping — any thoughts on this? Let me know if any changes are needed. |
Contributor
|
CI should pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1296
Problem
logfire runalways suggests installing instrumentation forsqlite3,urllib, andrequestsbecause:sqlite3andurllibare stdlib modules (always available)requestsis a dependency of OpenTelemetry itself (always in the environment)This is confusing for users who aren't actually using these packages.
Solution
Added an asterisk (
*) annotation to packages that are always detected (stdlib or OTel dependencies), with a footnote explaining they can be safely ignored if not used in the user's code.Example output:
This follows the suggestion from @DouweM in the issue discussion.