feat: Add cli_aliases to CLI settings
#624
Open
+68
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karta9821
force-pushed
the
support-cli-aliases
branch
5 times, most recently
from
ab6752c to
4eb7dd5
Compare
|
@maxnoe Please verify if it is okay |
|
@kschwab do you have time to take a look here? |
|
Thanks for the quick implementation, I played around with the branch here and it works as I would expect! Can't comment too much about the code itself. |
maxnoe
reviewed
Jun 3, 2025
`cli_aliases` is a mapping of alias name to field path.
karta9821
force-pushed
the
support-cli-aliases
branch
from
4eb7dd5 to
9abab16
Compare
|
please review |
|
I am waiting for @kschwab for a review, as he implemented most of the CLI settings source code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It addresses to #623
Selected Reviewer: @dmontagu