Skip to content

Deep git fetch to fix failing docs job on CI #2225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

gabalafou
Copy link
Collaborator

@gabalafou gabalafou commented Jun 24, 2025

Reference:
WARNING: Git clone too shallow
jdillard/sphinx-sitemap#109

Reference:
WARNING: Git clone too shallow pydata#109
<jdillard/sphinx-sitemap#109>
@gabalafou gabalafou changed the title Fix failing docs job on CI Do deep git fetch to fix failing docs job on CI Jun 24, 2025
@gabalafou gabalafou changed the title Do deep git fetch to fix failing docs job on CI Deep git fetch to fix failing docs job on CI Jun 24, 2025
@gabalafou gabalafou mentioned this pull request Jun 24, 2025
@trallard
Copy link
Collaborator

@gabalafou I just noticed you added the gallery screenshots to the repo, not sure if that is what we want to do moving forward. I know historically the generation was delegated to the script creating the gallery (on the fly) so I am wary about permanently adding the screenshots and these never being updated consistently as development work is carried out.

@gabalafou
Copy link
Collaborator Author

@gabalafou I just noticed you added the gallery screenshots to the repo

Yes right now, I'm just trying to get CI to turn green. Can change it later

@gabalafou
Copy link
Collaborator Author

gabalafou commented Jun 24, 2025

An alternative solution to the Sphinx Sitemap issue is to pin the version, as I do in #2227.

We need to decide how we want to move forward.

Perhaps the best option for right now is to pin the sitemap extension and then create an issue to update our docs, once jdillard/sphinx-sitemap#109 has gotten some feedback from the maintainers (the issue was opened only yesterday).

@gabalafou
Copy link
Collaborator Author

Since there are concerns with the approach taken in this PR and I don't have more time to devote to figuring out the other warnings generated by sphinx-sitemap version 2.7.0, I'm going to close this PR for now in favor of #2227. (Can always re-open it later if needed.)

@gabalafou gabalafou closed this Jun 24, 2025
trallard pushed a commit that referenced this pull request Jun 25, 2025
An alternative to #2225, addresses sphinx-sitemap issue 109:

- jdillard/sphinx-sitemap#109
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants