create class variable to hold config file entries prefix#419
Open
castalheiro wants to merge 4 commits intopydoit:masterfrom
Open
create class variable to hold config file entries prefix#419castalheiro wants to merge 4 commits intopydoit:masterfrom
castalheiro wants to merge 4 commits intopydoit:masterfrom
Conversation
Member
|
Hey, this is a good use-case. Right now the code assumes Are you sub-classing |
schettino72
requested changes
Mar 6, 2022
Member
schettino72
left a comment
There was a problem hiding this comment.
- Configurable through DoitMain instead of DoitConfig
- Flexible prefix configuration for any TOML filename (not only pyproject.toml)
1c01b5d to
8d297b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I intend to customize the configuration file entries prefix (e.g.tool.myapp.tasks.make_cookies instead of tool.doit.tasks.make_cookies). However, there is no global setting to replace all "doit" references with my own application name. Therefore i ended up creating a class variable that i can later modify without having to subclass DoitMain and DoitConfig classes.
This documentation page (https://pydoit.org/configuration.html#tool-doit-tasks) provides an example of the default setting.