-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Improve .llm code coverage
#10516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Improve .llm code coverage
#10516
Conversation
.llm code coveragellm/models/sentence_transformer.py and llm/models/vision_transformer.py
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10516 +/- ##
==========================================
+ Coverage 86.11% 87.53% +1.41%
==========================================
Files 496 510 +14
Lines 33655 35960 +2305
==========================================
+ Hits 28981 31476 +2495
+ Misses 4674 4484 -190 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
llm/models/sentence_transformer.py and llm/models/vision_transformer.py.llm code coverage
|
@puririshi98 @akihironitta |
puririshi98
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just plz address my one comment
puririshi98
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 more
|
@puririshi98 I forgot to force reload MoleculeDataset when llm switched to Qwen, so the text in the dataset was generated by TinyLlama but trained it with Qwen. master branch from scratchthis pr from scratch |
puririshi98
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay since the loss has dropped 2x on the test branch i think this is safe to merge just need CI to be green
|
@puririshi98 ready to merge. the same nightly PyTorch CI error as the master branch. |
hopefully @akihironitta can help w this |
|
@puririshi98 all CI passed |
|
Hi @puririshi98 what would be a good time to revisit and merge this PR? |
akihironitta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we only run rag tests in the workflow being deleted? I'd like to avoid this PR from almost tripling the CI time.
|
@akihironitta |
Issue
Close #10514, #10529
CodeCov
Before
After