Skip to content

Remove old executable overloads #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
pmrv wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Remove old executable overloads #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions pyiron_potentialfit/atomicrex/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,27 +220,6 @@ def write_input(self, directory=None):
self.potential.write_xml_file(directory=directory)
self.structures.write_xml_file(directory=directory)

def _executable_activate(self, enforce=False):
"""
Internal function that sets up and Executable() object
and finds executables available in pyiron resources/atomicrex/bin

Args:
enforce (bool, optional): [description]. Defaults to False.
"""
if self._executable is None or enforce:
if len(self.__module__.split(".")) > 1:
self._executable = Executable(
codename=self.__name__,
module=self.__module__.split(".")[-2],
path_binary_codes=state.settings.resource_paths,
)
else:
self._executable = Executable(
codename=self.__name__,
path_binary_codes=state.settings.resource_paths,
)

# Leftover of the potentials workshop.
# Maybe this property will be used in unified interface
# to several fitting codes in the future
Expand Down
14 changes: 0 additions & 14 deletions pyiron_potentialfit/mlip/mlip.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,20 +55,6 @@ def __init__(self, project, job_name):
self._command_line = CommandLine()
self._potential = MtpPotential()

def _executable_activate(self, enforce=False):
if self._executable is None or enforce:
if len(self.__module__.split(".")) > 1:
self._executable = Executable(
codename=self.__name__,
module=self.__module__.split(".")[-2],
path_binary_codes=state.settings.resource_paths,
)
else:
self._executable = Executable(
codename=self.__name__,
path_binary_codes=state.settings.resource_paths,
)

@property
def calculation_dataframe(self):
(
Expand Down