Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix img path issues #703

Merged
merged 3 commits into from
Oct 4, 2024
Merged

Fix img path issues #703

merged 3 commits into from
Oct 4, 2024

Conversation

B-Deforce
Copy link
Contributor

@B-Deforce B-Deforce commented Sep 19, 2024

The following images pooled.png, unpooled.png, and partial_pooled_model.png were wrongly assumed to reside in the same folder as the notebook and referred to as such in the notebook. Instead, they are located in ../case_studies/. These paths have now been fixed.


📚 Documentation preview 📚: https://pymc-examples--703.org.readthedocs.build/en/703/

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@OriolAbril
Copy link
Member

Thanks! Can you instead move the images to the generalized linear models folder? The notebook used to be in the case studies folder: https://github.com/pymc-devs/pymc-examples/tree/bed70e39355b6f4286b1c7aafa337e23bffa612b/examples/case_studies and it looks like it was moved without the images. Now that you have pointed out the issue, I don't think it makes sense to continue keeping the images in a different folder

@B-Deforce
Copy link
Contributor Author

You're right, moving the images makes more sense. Fixed it :).

@twiecki twiecki merged commit fc03395 into pymc-devs:main Oct 4, 2024
2 checks passed
@B-Deforce B-Deforce deleted the fix/path-issue branch October 4, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants