Skip to content

Allow transforms to work with multiple-valued nodes #6341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Nov 28, 2022

This showed up in pymc-devs/pymc-extras#91

https://github.com/pymc-devs/pymc-experimental/blob/5a01d4fc5d58fc1abb52f13fcb5cd4e8b32292ba/pymc_experimental/tests/test_marginal_model.py#L349-L368

Major / Breaking Changes

  • ...

Bugfixes / New features

  • Allow transforms for multiple_valued RVs

Docs / Maintenance

  • ...

@ricardoV94 ricardoV94 changed the title Allow transforms to work with multiple valued nodes Allow transforms to work with multiple-valued nodes Nov 28, 2022
@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Merging #6341 (3b5b84b) into main (ddc6b65) will decrease coverage by 2.06%.
The diff coverage is 98.80%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6341      +/-   ##
==========================================
- Coverage   94.71%   92.64%   -2.07%     
==========================================
  Files         132      132              
  Lines       26695    26751      +56     
==========================================
- Hits        25284    24784     -500     
- Misses       1411     1967     +556     
Impacted Files Coverage Δ
pymc/logprob/transforms.py 99.05% <97.82%> (-0.28%) ⬇️
pymc/tests/logprob/test_transforms.py 99.37% <100.00%> (+0.08%) ⬆️
pymc/tests/variational/test_updates.py 0.00% <0.00%> (-100.00%) ⬇️
pymc/tests/backends/test_arviz.py 0.00% <0.00%> (-99.03%) ⬇️
pymc/variational/updates.py 37.93% <0.00%> (-54.19%) ⬇️
pymc/backends/arviz.py 87.76% <0.00%> (-2.96%) ⬇️
pymc/model.py 89.62% <0.00%> (-0.14%) ⬇️

@ricardoV94 ricardoV94 force-pushed the fix_multiple_transformed_outputs branch 3 times, most recently from d85c3bd to 9e55b12 Compare November 28, 2022 17:23
@ricardoV94 ricardoV94 force-pushed the fix_multiple_transformed_outputs branch from 9e55b12 to 3b5b84b Compare December 5, 2022 15:29
Copy link
Member

@michaelosthege michaelosthege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm proud to have found something.

I get the idea and trust your test.

@ricardoV94 ricardoV94 force-pushed the fix_multiple_transformed_outputs branch from 3b5b84b to b66426f Compare December 8, 2022 17:54
@ricardoV94 ricardoV94 merged commit f1279fa into pymc-devs:main Dec 8, 2022
@zaxtax zaxtax removed their request for review December 9, 2022 01:06
@ricardoV94 ricardoV94 deleted the fix_multiple_transformed_outputs branch June 6, 2023 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants