-
Notifications
You must be signed in to change notification settings - Fork 2.2k
display variables in marimo #7967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7967 +/- ##
==========================================
- Coverage 91.48% 91.48% -0.01%
==========================================
Files 116 116
Lines 18962 18969 +7
==========================================
+ Hits 17348 17353 +5
- Misses 1614 1616 +2
🚀 New features to boost your workflow:
|
ericmjl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Do you reckon we'll need to start testing the marimo-related features?
| ) | ||
|
|
||
| # https://docs.marimo.io/guides/integrating_with_marimo/displaying_objects/#option-1-implement-a-_display_-method | ||
| rv_out._display_ = types.MethodType(functools.partial(safe_display, model=model), rv_out) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's a good time as any to remove pretty print from the variables and leave it to the model graphviz only.
There was an issue/ PR to remove those others for ipython. This is never going to be exhaustive because there are many other ways of creating variables for models
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So does that mean, removing other pretty print methods as well? I'm not following your comment fully.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, only the model remains with pretty print
|
This goes in the opposite direction I suggest we should take in #7712 Also graph representation instead of textual by default seems very verbose |


Description
This uses the
model_to_mermaidfunction for generating graph for a specific variable in the model.Method bound to:
Related Issue
Checklist
Type of change