Fix scalar Blockwise in numba backend #1846
Merged
+69
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
added
bug
11 tasks
jessegrabowski
approved these changes
Jan 13, 2026
| *safe, | ||
| ) | ||
| if core_ndim == 0: | ||
| if core_scalar and core_ndim == 0: |
Member
There was a problem hiding this comment.
what if core_ndim == 0 but not core_scalar (the old case)?
Member
Author
There was a problem hiding this comment.
The old case is this branch, it's what happens with elemwise. In that case the inner function gets a scalar not a 0d array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1760
Inner functions of Blockwise will always get 0d arrays and not scalars, unlike Elemwise/RandomVariable inner functions.
This is also what the python impl of Blockwise already did, although it's not what numpy
vectorizedoes. AFAICT there's no syntax to distinguish, but 0d array should be more robust (if more wasteful). It will also avoid numba/numba#10358Most Blockwise Ops shouldn't have scalar inputs, or if they do, the cost of accessing them shouldn't dominate the runtime.
Cherry picked from #1806