Add test entries for PYODIDE_INTERPRETER and PYODIDE_PACKAGE_INDEX
#207
Conversation
pyodide_build/tests/test_config.py
Outdated
| "interpreter" = "$(PYODIDE_INTERPRETER)" | ||
| "package_index" = "$(PYODIDE_PACKAGE_INDEX)" |
There was a problem hiding this comment.
I don't think we expect people to overwrite these configs.
There was a problem hiding this comment.
Yes, this is with the in-tree case, I'll drop it. What should be the scenario with the out-of-tree case?
There was a problem hiding this comment.
I don't think people would want to overwrite these variables in out-of-tree as well. The interpreter is coming from the xbuildenv, and the package_index is created by pyodide venv. I guess these variables are used mostly for getting the path for these values rather than overwriting it?
|
I agree with you here, @ryanking13 and @hoodmane does too – I don't see anyone in the near future trying to override the package index without horribly breaking their ABI compatibility due to a runtime, and we don't have a nice way to deal with this until #88, so I would be fine with closing this. We already have tests that check the existence of the keys and vars, so this might be redundant. Thanks for the review! |
This PR should add a few test entries for #199.
cc: @hoodmane