Walking reconstruction example

[EveCharbie]

This change is 

[codeclimate]

The PR diff size of 106451 lines exceeds the maximum allowed for the inline comments feature.

[EveCharbie]

@Ipuch : My bad, we fixed my environment problem together. So this was already OK and reviewed.

[Ipuch]

@EveCharbie can you try to merge all vtp in one folder ? To avoid duplication of .vtp files ? make sure my msk example still work.

[EveCharbie]

Could you please explain a bit more ?
Do you mean folder or file ?
I kind of like that the files are the "same" as OpenSim, that way it is easy for users to go from osim to biomod ( #BioBuddy ;) )

[Ipuch]

I mean I have a folder for meshes for my upper limb example. Some of the vtp files are the same. To avoid the redundancy we could merge the folders and reduce the size of the Pr/repo git history.

I also means your pr needs a force-push.

[EveCharbie]

I don't understand since I already put my vtp files in your folder examples/biorbd/models/Geometry_cleaned.
The only redundancy I see is for the left/right sides: e.g., I have humerus_rv.vtp + humerus_lv.vtp and you have humerus.vtp.
But since humerus.vtp and humerus_rv.vtp are not the same size, I cannot tell if they are the same.
Could you maybe do it for me since we do not seem to understand each other by text ?

[Ipuch]

okay for the redundancy. The first part of your last answer, made it clearer that files are not the same for your example and mine.

Still, there are three pbs:

• The index_proximal_rvs vtp has an offset
• The spine (hat_spine.vtp) has an offset
• The thorax(hat_ribs_scap.vtp) has not been well converted to a proper triangle mesh

Do you have these problems locally too ?

[codeclimate]

Code Climate has analyzed commit 44ca9cd and detected 0 issues on this pull request.

View more on Code Climate.

[EveCharbie]

Unfortunately, those are problems related to osim_to_biomod :(
I have removed the vtp that had an offset (so that the problem is not noticeable, but it is not fixed).
For the vtp that was not cleaned properly, I think we will have to accept it as is for now. And when I manage to clean it correctly, I will make another small PR.