Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding enable #2048

Merged
merged 4 commits into from
Nov 14, 2024
Merged

feat: adding enable #2048

merged 4 commits into from
Nov 14, 2024

Conversation

henryiii
Copy link
Contributor

@henryiii henryiii commented Oct 19, 2024

Close #2045. Adds enable, deprecates the old way of specifying these (remove in 3.0).

cibuildwheel/util.py Outdated Show resolved Hide resolved
@henryiii henryiii mentioned this pull request Oct 21, 2024
@henryiii henryiii force-pushed the henryiii/feat/enable branch 2 times, most recently from cc80f2c to bbc0a19 Compare November 1, 2024 15:11
@henryiii henryiii changed the title WIP: start adding enable feat: adding enable Nov 1, 2024
cibuildwheel/options.py Outdated Show resolved Hide resolved
Signed-off-by: Henry Schreiner <[email protected]>
@henryiii henryiii marked this pull request as ready for review November 6, 2024 05:25
Signed-off-by: Henry Schreiner <[email protected]>
@mayeut
Copy link
Member

mayeut commented Nov 9, 2024

There are too many warnings issued for a single build. I will push some commits to rework deprecation notices.

pybase64 % cibuildwheel --platform=linux
Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead


     _ _       _ _   _       _           _
 ___|_| |_ _ _|_| |_| |_ _ _| |_ ___ ___| |
|  _| | . | | | | | . | | | |   | -_| -_| |
|___|_|___|___|_|_|___|_____|_|_|___|___|_|

cibuildwheel version 2.21.3

Build options:
  platform: linux
Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

  allow_empty: False
  architectures: aarch64
  build_selector: 
    build_config: *
    skip_config: 
    requires_python: >=3.8
    enable: ['cpython-freethreading', 'pypy']
  output_dir: /Users/Matt/Dev/base64/pybase64/wheelhouse
  package_dir: /Users/Matt/Dev/base64/pybase64
  test_selector: 
    skip_config: *-win_arm64
  before_all: 
  before_build: 
  before_test: 
  build_frontend: None
  build_verbosity: 1
  config_settings: 
  container_engine: docker
  dependency_constraints: pinned
  environment: 
    *: 
    cp38-manylinux_aarch64, cp39-manylinux_aarch64, cp310-manylinux_aarch64, cp311-manylinux_aarch64, cp312-manylinux_aarch64, cp313-manylinux_aarch64, cp313t-manylinux_aarch64, pp38-manylinux_aarch64, pp39-manylinux_aarch64, pp310-manylinux_aarch64: 
      AUDITWHEEL_PLAT="manylinux2014_${AUDITWHEEL_ARCH}"
  manylinux_images: 
    x86_64: quay.io/pypa/manylinux_2_28_x86_64:2024.11.03-3
    i686: quay.io/pypa/manylinux2014_i686:2024.11.03-3
    pypy_x86_64: quay.io/pypa/manylinux_2_28_x86_64:2024.11.03-3
    aarch64: quay.io/pypa/manylinux_2_28_aarch64:2024.11.03-3
    ppc64le: quay.io/pypa/manylinux_2_28_ppc64le:2024.11.03-3
    s390x: quay.io/pypa/manylinux_2_28_s390x:2024.11.03-3
    pypy_aarch64: quay.io/pypa/manylinux_2_28_aarch64:2024.11.03-3
    pypy_i686: quay.io/pypa/manylinux2014_i686:2024.11.03-3
  musllinux_images: 
    x86_64: quay.io/pypa/musllinux_1_2_x86_64:2024.11.03-3
    i686: quay.io/pypa/musllinux_1_2_i686:2024.11.03-3
    aarch64: quay.io/pypa/musllinux_1_2_aarch64:2024.11.03-3
    ppc64le: quay.io/pypa/musllinux_1_2_ppc64le:2024.11.03-3
    s390x: quay.io/pypa/musllinux_1_2_s390x:2024.11.03-3
    armv7l: quay.io/pypa/musllinux_1_2_armv7l:2024.11.03-3
  repair_command: auditwheel repair -w {dest_dir} {wheel}
  test_command: pytest {project}/tests
  test_extras: 
  test_groups: 
  test_requires: 
    -r
    requirements-test.txt

Cache folder: /Users/Matt/Library/Caches/cibuildwheel

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Here we go!

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Starting container image quay.io/pypa/manylinux_2_28_aarch64:2024.11.03-3...

info: This container will host the build for cp38-manylinux_aarch64, cp39-manylinux_aarch64, cp310-manylinux_aarch64, cp311-manylinux_aarch64, cp312-manylinux_aarch64, cp313-manylinux_aarch64, cp313t-manylinux_aarch64, pp38-manylinux_aarch64, pp39-manylinux_aarch64, pp310-manylinux_aarch64...
+ docker version -f '{{json .}}'
Cannot connect to the Docker daemon at unix:///Users/Matt/.docker/run/docker.sock. Is the docker daemon running?

                                                              ✕ 0.12s
Error: Build failed because docker is too old or is not working properly.

@mayeut
Copy link
Member

mayeut commented Nov 9, 2024

The warnings now show as:

pybase64 % cibuildwheel --platform=linux
Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: PyPy builds will be disabled by default in version 3. Enabling PyPy builds should be specified by enable


     _ _       _ _   _       _           _
 ___|_| |_ _ _|_| |_| |_ _ _| |_ ___ ___| |
|  _| | . | | | | | . | | | |   | -_| -_| |
|___|_|___|___|_|_|___|_____|_|_|___|___|_|

cibuildwheel version 2.21.3

Build options:
....

@henryiii henryiii merged commit 393e035 into pypa:main Nov 14, 2024
24 checks passed
@henryiii henryiii deleted the henryiii/feat/enable branch November 14, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-default identifiers?
2 participants