Skip to content

Handle nonzero version epoch in StandardScheme (fix #1032)#1036

Merged
ofek merged 5 commits intopypa:masterfrom
object-Object:fix-epoch
Nov 26, 2023
Merged

Handle nonzero version epoch in StandardScheme (fix #1032)#1036
ofek merged 5 commits intopypa:masterfrom
object-Object:fix-epoch

Conversation

@object-Object
Copy link
Contributor

This fixes #1032, where hatch version would strip version epochs when incrementing the version.

As far as I can tell, it's fine to remove epoch: 0 here because version._version.epoch defaults to 0 if not set.

Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ofek ofek merged commit 63d676b into pypa:master Nov 26, 2023
github-actions bot pushed a commit that referenced this pull request Nov 26, 2023
* Handle nonzero version epoch in StandardScheme (fix #1032)

* Fix wrong name type in pytest.mark.parametrize

* add release note

---------

Co-authored-by: Ofek Lev <ofekmeister@gmail.com> 63d676b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hatch version strips version epochs (eg. 1!1.0)

2 participants