Fix the wheel target for case insensitive file systems
#1080
Conversation
|
Thanks! Let me test it... |
|
| @staticmethod | ||
| def get_raw_fs_path_name(directory: str, name: str) -> str: | ||
| normalized = name.casefold() | ||
| entries = os.listdir(directory) |
There was a problem hiding this comment.
Friendly tip: maybe you want to limit this to platform.system() == "Darwin"? In Pygments, hatchling is ~2× faster to build a wheel than setuptools, and I suspect this is in part because it saves lots of syscalls for listdir() in our huge test/ tree. Now, the way this function is used right now, this is not very likely to matter a great deal because I'd expect the package directory not to have hundreds of files, unlike some test directories, but still...
There was a problem hiding this comment.
This also applies to Windows, sure I will not do this on Linux! Before I do however, did this fix it for you?
There was a problem hiding this comment.
Yes, it seems to be working on the macOS machine I have access to.
Resolves #1054