Assorted MyPy improvments #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unused "type: ignore" comment [unused-ignore]
Must not have show_error_codes. It is now the default.
DimitriPapadopoulos
force-pushed
the
mypy
branch
13 times, most recently
from
239b84a
to
6f5af15
Compare
DimitriPapadopoulos
force-pushed
the
mypy
branch
from
6f5af15
to
6b89efd
Compare
|
|
||
| installed_distributions = DistributionCache(sys_path) | ||
| return all(dependency_in_sync(requirement, environment, installed_distributions) for requirement in requirements) | ||
| return all(dependency_in_sync(requirement, environment, installed_distributions) for requirement in requirements) # type: ignore[arg-type] |
There was a problem hiding this comment.
This a real issue:
dependencies_in_sync/dependency_in_syncrequireenvironmentto be adict[str, str]:
hatch/backend/src/hatchling/cli/dep/core.py
Lines 123 to 124 in 7c8dbbc
packaging.markers.default_environmentreturns anEnvironmentwhich is aTypedDict
Not sure how to best handle this. Change dependencies_in_sync/dependency_in_sync to expect Environment or TypedDict? Cast the result from default_environment to a dict[str, str]?
djcopley
suggested changes
Aug 7, 2024
This will force all skips to include the error code, which makes them more readable, and avoids skipping something unintended.
This catches mistakes in using a value as truthy if it cannot be falsey.
DimitriPapadopoulos
force-pushed
the
mypy
branch
from
6b89efd
to
830c25c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.