Skip to content

Support a SOURCE_DATE_EPOCH prior to 1980 #1999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cjames23 merged 4 commits into from
Feb 3, 2026
Merged

Support a SOURCE_DATE_EPOCH prior to 1980 #1999

cjames23 merged 4 commits into from
Feb 3, 2026
+13 −4

Conversation

@branchv
Copy link
Contributor

@branchv branchv commented Jun 11, 2025

Fixes #1605

A common value for SOURCE_DATE_EPOCH is 0, which unfortunately breaks hatchling:

$ uv init --build-backend=hatch
$ SOURCE_DATE_EPOCH=0 uv build
# ...
  File "/opt/homebrew/Cellar/[email protected]/3.13.4/Frameworks/Python.framework/Versions/3.13/lib/python3.13/zipfile/__init__.py", line 412, in __init__
    raise ValueError('ZIP does not support timestamps before 1980')
ValueError: ZIP does not support timestamps before 1980

This clamps to 1980 instead (same as setuptools and flit-core. poetry also support this but defaults to 2016)

@branchv branchv mentioned this pull request Jun 11, 2025
Merged
ofek
ofek requested changes Sep 29, 2025
View reviewed changes
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@branchv branchv requested a review from ofek September 29, 2025 05:02
@branchv branchv mentioned this pull request Oct 25, 2025
Merged
6 tasks
@chenrui333 chenrui333 mentioned this pull request Oct 27, 2025
Merged
@branchv
Copy link
Contributor Author

branchv commented Dec 10, 2025

@ofek @cjames23 sorry for the ping, but Homebrew has been working around this bug for a while so I'd love to see this merged

@branchv branchv force-pushed the source-date-epoch branch from a4cba26 to bc8804a Compare January 9, 2026 19:11
@cjames23
Copy link
Member

cjames23 commented Jan 29, 2026

I will need to get a PR out to address the changes with Rich in 14.3 this week to merge this.

@davep davep mentioned this pull request Jan 31, 2026
Open
davep added a commit to davep/homebrew-homebrew that referenced this pull request Jan 31, 2026
@davep
🐛 Attempt a workaround for pypa/hatch#1999
beccde4 
Which should help out with davep/hike#142
@cjames23 cjames23 enabled auto-merge (squash) February 3, 2026 23:43
@cjames23 cjames23 disabled auto-merge February 3, 2026 23:44
@cjames23 cjames23 merged commit f400be1 into pypa:master Feb 3, 2026
94 of 99 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjames23 cjames23 cjames23 approved these changes

@ofek ofek Awaiting requested review from ofek

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

zipfile will fail if SOURCE_DATE_EPOCH is before 1980

3 participants

@branchv @cjames23 @ofek