Skip to content

Draft index_priority #13293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Draft index_priority #13293

wants to merge 1 commit into from

Conversation

atalman
Copy link

@atalman atalman commented Mar 20, 2025

Working with @msarahan on Index Priority. #13210

Hack way of prioritizing indexes

Test 1:
pip install torch --index-groups https://download.pytorch.org/whl/test/cpu,https://download.pytorch.org/whl/nightly/cpu --force-reinstall --dry-run

Output:

 pip install torch --index-groups https://download.pytorch.org/whl/test/cpu,https://download.pytorch.org/whl/nightly/cpu --force-reinstall --dry-run
https://download.pytorch.org/whl/test/cpu,https://download.pytorch.org/whl/nightly/cpu
Looking in indexes: https://download.pytorch.org/whl/test/cpu, https://download.pytorch.org/whl/nightly/cpu
Collecting torch
  Using cached https://download.pytorch.org/whl/test/cpu/torch-2.7.0%2Bcpu-cp311-cp311-manylinux_2_28_x86_64.whl.metadata (27 kB)
Collecting filelock (from torch)
  Using cached https://download.pytorch.org/whl/test/filelock-3.13.1-py3-none-any.whl (11 kB)
Collecting typing-extensions>=4.10.0 (from torch)
  Using cached https://download.pytorch.org/whl/test/typing_extensions-4.12.2-py3-none-any.whl (37 kB)
Collecting sympy>=1.13.3 (from torch)
  Using cached https://download.pytorch.org/whl/test/sympy-1.13.3-py3-none-any.whl.metadata (12 kB)
Collecting networkx (from torch)
  Using cached https://download.pytorch.org/whl/test/networkx-3.3-py3-none-any.whl (1.7 MB)
Collecting jinja2 (from torch)
  Using cached https://download.pytorch.org/whl/test/Jinja2-3.1.4-py3-none-any.whl (133 kB)
Collecting fsspec (from torch)
  Using cached https://download.pytorch.org/whl/test/fsspec-2024.6.1-py3-none-any.whl (177 kB)
Collecting mpmath<1.4,>=1.1.0 (from sympy>=1.13.3->torch)
  Using cached https://download.pytorch.org/whl/test/mpmath-1.3.0-py3-none-any.whl (536 kB)
Collecting MarkupSafe>=2.0 (from jinja2->torch)
  Using cached https://download.pytorch.org/whl/test/MarkupSafe-2.1.5-cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (28 kB)
Using cached https://download.pytorch.org/whl/test/cpu/torch-2.7.0%2Bcpu-cp311-cp311-manylinux_2_28_x86_64.whl (176.0 MB)
Using cached https://download.pytorch.org/whl/test/sympy-1.13.3-py3-none-any.whl (6.2 MB)
Would install Jinja2-3.1.4 MarkupSafe-2.1.5 filelock-3.13.1 fsspec-2024.6.1 mpmath-1.3.0 networkx-3.3 sympy-1.13.3 torch-2.7.0+cpu typing_extensions-4.12.2

Test 2:
pip install torch --index-groups https://download.pytorch.org/whl/nightly/cpu,https://download.pytorch.org/whl/test/cpu --force-reinstall --dry-run

Output:

pip install torch --index-groups https://download.pytorch.org/whl/nightly/cpu,https://download.pytorch.org/whl/test/cpu --force-reinstall --dry-run
https://download.pytorch.org/whl/nightly/cpu,https://download.pytorch.org/whl/test/cpu
Looking in indexes: https://download.pytorch.org/whl/nightly/cpu, https://download.pytorch.org/whl/test/cpu
Collecting torch
  Using cached https://download.pytorch.org/whl/nightly/cpu/torch-2.8.0.dev20250320%2Bcpu-cp311-cp311-manylinux_2_28_x86_64.whl.metadata (27 kB)
Collecting filelock (from torch)
  Using cached https://download.pytorch.org/whl/nightly/filelock-3.16.1-py3-none-any.whl (16 kB)
Collecting typing-extensions>=4.10.0 (from torch)
  Using cached https://download.pytorch.org/whl/nightly/typing_extensions-4.12.2-py3-none-any.whl (37 kB)
Collecting sympy>=1.13.3 (from torch)
  Using cached https://download.pytorch.org/whl/nightly/sympy-1.13.3-py3-none-any.whl (6.2 MB)
Collecting networkx (from torch)
  Using cached https://download.pytorch.org/whl/nightly/networkx-3.4.2-py3-none-any.whl (1.7 MB)
Collecting jinja2 (from torch)
  Using cached https://download.pytorch.org/whl/nightly/jinja2-3.1.4-py3-none-any.whl (133 kB)
Collecting fsspec (from torch)
  Using cached https://download.pytorch.org/whl/nightly/fsspec-2024.10.0-py3-none-any.whl (179 kB)
Collecting mpmath<1.4,>=1.1.0 (from sympy>=1.13.3->torch)
  Using cached https://download.pytorch.org/whl/nightly/mpmath-1.3.0-py3-none-any.whl (536 kB)
Collecting MarkupSafe>=2.0 (from jinja2->torch)
  Using cached https://download.pytorch.org/whl/nightly/MarkupSafe-2.1.5-cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (28 kB)
Using cached https://download.pytorch.org/whl/nightly/cpu/torch-2.8.0.dev20250320%2Bcpu-cp311-cp311-manylinux_2_28_x86_64.whl (177.6 MB)
Would install Jinja2-3.1.4 MarkupSafe-2.1.5 filelock-3.16.1 fsspec-2024.10.0 mpmath-1.3.0 networkx-3.4.2 sympy-1.13.3 torch-2.8.0.dev20250320+cpu typing_extensions-4.12.2

@pfmoore
Copy link
Member

pfmoore commented Mar 20, 2025

I'm not sure what you want here. If this is a "hack way", it's clearly not ready for review or testing. As far as I can see, there's not even a clear design - there's barely any documentation, and no examples of use cases.

There's so far been no response on #13210, so if this is intended to build on that, it seems a little premature.

I'd suggest you work on this locally, and come up with a complete design before posting a PR here.

@atalman
Copy link
Author

atalman commented Mar 20, 2025

Hi @pfmoore yes closing this for now, sorry about the noise

@atalman atalman closed this Mar 20, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants