Simplify test for pip and set minimum version

Co-authored-by: Sviatoslav Sydorenko <[email protected]>
pypa · Dec 1, 2023 · ddd41e3 · ddd41e3
1 parent 51a010b
commit ddd41e3
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 9 deletions.
diff --git a/src/pipx/commands/install.py b/src/pipx/commands/install.py
@@ -59,10 +59,7 @@ def install(
 
     try:
         # Enable installing shared library `pip` with `pipx`
-        override_shared = False
-
-        if package_name == "pip":
-            override_shared = True
+        override_shared = package_name == "pip"
         venv.create_venv(venv_args, pip_args, override_shared)
         for dep in preinstall_packages or []:
             dep_name = package_name_from_spec(

diff --git a/src/pipx/commands/run.py b/src/pipx/commands/run.py
@@ -226,10 +226,7 @@ def _download_and_run(
             package_or_url, python, pip_args=pip_args, verbose=verbose
         )
 
-    override_shared = False
-
-    if package_name == "pip":
-        override_shared = True
+    override_shared = package_name == "pip"
 
     venv.create_venv(venv_args, pip_args, override_shared)
     venv.install_package(

diff --git a/src/pipx/shared_libs.py b/src/pipx/shared_libs.py
@@ -106,7 +106,7 @@ def upgrade(
                         "install",
                         *_pip_args,
                         "--upgrade",
-                        "pip",
+                         "pip >= 23.1",
                     ]
                 )
             subprocess_post_check(upgrade_process)