-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass --no-input #1029
Pass --no-input #1029
Conversation
8e0e6ba
to
fdc4967
Compare
src/pipx/venv.py
Outdated
cmd = ( | ||
["--no-input", "install", "--no-dependencies"] | ||
+ pip_args | ||
+ [package_or_url] | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cmd = ( | |
["--no-input", "install", "--no-dependencies"] | |
+ pip_args | |
+ [package_or_url] | |
) | |
cmd = [ | |
"--no-input", | |
"install", | |
"--no-dependencies", | |
*pip_args, | |
package_or_url, | |
] |
We should probably use this chance to change other command-building code as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some in the form of cmd = [<snip>] + cmd
alone instead of changing it to cmd = [<snip>, *cmd]
.
docs/changelog.md
Summary of changes
Pass
--no-input
to Pip.Fixes #219
This is a breaking change for keyring users. But was it ever properly supported anyway? As someone who needs the
artifacts-keyring
package to authenticate with our private repo I'm going with the answer beingno, you will have to apply hacks if this is important to you
. Failing fast is better then hanging forever because the user can't see the prompt asking for a username and password.pypa/pip#11698 which is released in Pip 23.1 added a section to the documentation how Pipx users who rely on the keyring library can set things up so keyring will be used again: https://pip.pypa.io/en/stable/topics/authentication/#using-keyring-as-a-command-line-application.
Test plan
It should not have any impact when keyring is not required to authenticate with the repository.
Tested by running the test suite.