Relax VenvInspectInformation attribute typing

[aanghelidi]

Description

This PR aims to remove the explicit call to list() made in venv_inspect.py by using the type that importlib.metadata.distributions() returns (an Iterator from itertools.chain.from_iterable, see) from wrapping Distribution.discover(**kwargs).

However, the code logic would be flawed if we used an Iterator (in this case skipping the explicit list() call) because we could only iterate on it once and need to do it multiple times in _dfs_package_apps to retrieve the dependencies for a given package correctly.

Therefore, an Iterable was used as a more generic type hint for more flexibility, and tuple was used instead of list since we are not modifying VenvInspectInformation.distributions.

• I have added an entry to docs/changelog.md

Summary of changes

• Import Iterable from typing
• Replace all the corresponding type hints
• Swap the explicit list() call to a tuple() call

Test plan

Tested by running

nox -s lint
nox -s tests-3.11

Resolves: #629

[dukecat0]

Thanks for your description, and it looks good to me generally. 👍

[uranusjr]

I would prefer Collection here, since Iterable sort of hints you are only expected to interate through this at most once (which is not the case).

[aanghelidi]

Thank you for your feedback @uranusjr 👍 The last commit reflects this change.

[dukecat0]

Looks like some tests are failed with this error: TypeError: 'ABCMeta' object is not subscriptable

[aanghelidi]

As described here collections.abc.Collection can only be subscripted since 3.9, hence this error. The last commit should fix this issue. Let me know what you think.

[uranusjr]

Doing a sys.version_info check just for this seems a bit redundant. I’d just use the typing entry for now, or add a from __future__ import annotations to make the annotation not resolve at runtime instead.

[aanghelidi]

I added typing.Collection as I'm less familiar with from __future__ import annotations.

[dukecat0]

Thanks!